Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update iping build to work with iRODS v4.3.0 #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update iping build to work with iRODS v4.3.0 #27

wants to merge 1 commit into from

Conversation

Pansanel
Copy link
Contributor

@Pansanel Pansanel commented Jul 2, 2022

The modification of the CMakeLists.txt file are based on the content of the CMakeLists.txt file from the irods_client_rest_cpp client project. Some unused includes have been removed from the iping.cpp.

@Pansanel
Copy link
Contributor Author

Pansanel commented Jul 4, 2022

This PR has been successfully tested with CentOS 7 and Ubuntu 18.04 Bionic.

@korydraughn
Copy link

@Pansanel Thanks for this.

How was this tested?
Did you test this using the irods_development_environment and irods_testing_environment?

  • Those repos would allow you to test against all supported platforms

@SwooshyCueb Please review the cmake changes for possible issues.

@trel trel changed the title Update files to work with iRODS v4.3.0 Update iping build to work with iRODS v4.3.0 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pansanel @korydraughn